segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Fix forwarded select ref #1435

Closed brandongregoryscott closed 2 years ago

brandongregoryscott commented 2 years ago

Overview

Fixes #1434

Updates the ref in <Select /> to be passed to the <Box is="select" /> vs the wrapping <Box /> that's used for styling. To test this, I created an object in the shape of a standard ref and ensure it is the correct HTMLElement instance. The current tests that we have for forwarding refs are fine for ensuring the refs go somewhere, but can't test what the ref goes to without updating the shape of the object.

Screenshots (if applicable)

Documentation

netlify[bot] commented 2 years ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 02a0611ef9fc4913090b2286a3970218f4bda4b1
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/62532420d30bb60009f401ff
Deploy Preview https://deploy-preview-1435--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.