segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Widen Text size PropType to accept small, medium or large #1449

Closed brandongregoryscott closed 2 years ago

brandongregoryscott commented 2 years ago

The Text component's size PropType should be widened to accept small, medium or large since our default theme remaps 300, 400 and 500 to those theme values anyway:

https://github.com/segmentio/evergreen/blob/10e8e2399029a22526b55e3f532a0c0b81952696/src/themes/default/components/text.js#L32-L37

Sam-Radnus commented 2 years ago

is the issue still open ??

brandongregoryscott commented 2 years ago

is the issue still open ??

Yep!