search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Unrequired length check in autocomplete #1489

Closed cogwizzle closed 2 years ago

cogwizzle commented 2 years ago

Overview I noticed that we were performing a similar check twice in the same file when reviewing the large upcoming typescript change. I tried to update the code to remove the redundancy. A small change but every little bit helps.

Documentation

netlify[bot] commented 2 years ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 3398ab5c0f5bbe6b46daa331437702224c3b6ddb
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/62bda20f69760d0008d93a6a
Deploy Preview https://deploy-preview-1489--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cogwizzle commented 2 years ago

If it helps get me workflow approval I did run my test locally and they passed.