Closed TIMMLOPK closed 2 years ago
Name | Link |
---|---|
Latest commit | 911f495772f2f3033cc544703e0d2bf5738640dc |
Latest deploy log | https://app.netlify.com/sites/evergreen-storybook/deploys/62bbdbff1ec75800084fe8c8 |
Deploy Preview | https://deploy-preview-1490--evergreen-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Would this break any existing functionality? I can see that the current version supports the logic that you recommended but I am just curious if it would break existing codebases that haven't updated to 12.x yet. I can't find older documentation, but here is some documentation from NEXT supporting @TIMMLOPK's change. https://nextjs.org/docs/advanced-features/custom-document#customizing-renderpage
@TIMMLOPK Did you mean v12.2+? I don't think NextJS has a v12.6 out yet: https://www.npmjs.com/package/next
In either case, I'm not sure I'm able to reproduce this. Can you provide a CodeSandbox for reproduction?
@TIMMLOPK Did you mean v12.2+? I don't think NextJS has a v12.6 out yet: https://www.npmjs.com/package/next
In either case, I'm not sure I'm able to reproduce this. Can you provide a CodeSandbox for reproduction?
It is 12.1.6,I correct it.I would try to make reproduction
@brandongregoryscott seem can't make it in codesandbox because it crash.I made a repo for it :https://github.com/TIMMLOPK/error-reproduction
Would this break any existing functionality? I can see that the current version supports the logic that you recommended but I am just curious if it would break existing codebases that haven't updated to 12.x yet. I can't find older documentation, but here is some documentation from NEXT supporting @TIMMLOPK's change. https://nextjs.org/docs/advanced-features/custom-document#customizing-renderpage
No , I tried to use 11.x ,it doesn't matter
Ah, ok. I see the issue in my console using that version (and again when I updated to 12.2.0 - not sure why I wasn't seeing it before, perhaps it wasn't actually running the latest version)
This change seems to work in the version we have specified in the package.json too (12.1.0), so I think this is fine to update. Thanks!
Overview If using nextjs
=>12.1.6
, may geterror: "MyDocument.getInitialProps()" should resolve to an object with a "html" prop set with a valid html string
Documentation