search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Autocomplete: `allowOtherValues` not working? #1496

Closed egg-juxt closed 2 years ago

egg-juxt commented 2 years ago

Hi, this doesn't seem to be correct behavior: I'm using Autocomplete with property allowOtherValues enabled. When I select an item from the Autocomplete menu, the input value does not get updated.

Reproduction steps: Navigate to https://evergreen.segment.com/components/autocomplete#default_example Click on "Open in CodeSandbox". Check that the Autocomplete component is working correctly. Edit sample code to add property allowOtherValues to the Autocomplete element. Refresh the "Browser" frame in CodeSandbox. Select an item in Autocomplete and verify that it is not updating the value of the input element.

brandongregoryscott commented 2 years ago

Hmm, yeah, it looks like you're right. It looks like it does select the value (typing in 'a', selecting Apple, backspacing, and then typing 'a' again shows the Apple option selected) but it doesn't seem to be properly updating the input field. Not sure when/if this ever worked, but going as far back as 6.4.0 it is still showing this behavior.

brandongregoryscott commented 2 years ago

This should be resolved in https://github.com/segmentio/evergreen/releases/tag/v6.10.4