segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Adds HTML name attribute support for RadioGroup #1524

Closed fs-nathan closed 1 year ago

fs-nathan commented 1 year ago

Overview Currently the RadioGroup component automatically generates a string prefix 'RadioGroup' for the HTML name attribute on input type radio. This PR is about to add a name prop support for the component so the developer can set the attribute on their own and have more controls of form radio buttons on both client side and server side if they need it.

A recent issue is #1522

Screenshots (if applicable)

Before this change image

After this change image

Documentation

Testing

Added new unit test and run test on local

image

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 0124f858e2b5c6884a49e2a67190bb5137b3444f
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/633497c29d6727000ad26a06
Deploy Preview https://deploy-preview-1524--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

fs-nathan commented 1 year ago

Hi @brandongregoryscott Would you mind reviewing this PR? Thank you!