segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Omit children, items, and onChange from Combobox.autocompleteProps #1526

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Fixes #1525

items, children and onChange are required properties in AutocompleteProps, but they are passed in as top-level props for the Combobox. You'd need to cast any object you pass in if you wanted to override specific Autocomplete behavior. This should be closer to the intended usage of the component and ease the need to cast any props you're sending thru it, if you really need to.

Overview

Screenshots (if applicable)

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit ce35bfa2b953bab73d705435668be81cdefb40c8
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/63581f9c3299c8000914562e
Deploy Preview https://deploy-preview-1526--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.