segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Fix: allow OptionsList to not focus on the search bar #1528

Closed chenxzhang closed 1 year ago

chenxzhang commented 1 year ago

Original Jira ticket: https://segment.atlassian.net/browse/PROT-4257 Loom: https://www.loom.com/share/79fd27a5ac2a415c93aac856c50c427a

Overview There's a bug in Protocols tracking plan, where the focus of the input changes to the focus of the filter search bar. This happens because the tracking plan editor pages refreshes every few seconds and the focus is autofocused to the search bar component. This PR adds a prop shouldAutoFocus to OptionsList so that we can disable the autofocus as needed. The change will not affect existing behaviors.

Screenshots (if applicable)

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit e7e5ee63d8a96a276326244adc0cfacdc401245b
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/63409c58ffdbd10009a20fd4
Deploy Preview https://deploy-preview-1528--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.