segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

FileUploader - Remove custom <Text /> wrapping validationMessage #1532

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Overview The FileUploader component had different behavior for a validationMessage passed as props vs. the one that was shown for the maxFiles error while dragging - no error icon was being shown. For consistency with other components leveraging <FormField />, let's just stick with the default behavior.

Screenshots (if applicable)

image Going to double check w/ design on this - this seems like incorrect scaling behavior for a validation message that might wrap to multiple lines. Looking at the source code, <FormFieldValidationMessage /> is its own implementation of what really looks like an <InlineAlert />

I think this can be a separate issue ☝️ since it's not unique to the FileUploader.

When dragging: FileUploader - Dragging with FormFieldValidationMessage

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 4145d898cfa9dca4e40641252c48277626d8f417
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/634980a779470400083097d4
Deploy Preview https://deploy-preview-1532--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.