segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

feat(FilePicker): props for i18n support #1541

Closed KillerCodeMonkey closed 1 year ago

KillerCodeMonkey commented 1 year ago

Overview

Screenshots (if applicable)

no file Screenshot_20221027_134837

one file Screenshot_20221027_134858

multiple files Screenshot_20221027_134914

Documentation

KillerCodeMonkey commented 1 year ago

hey :wave:,

one question: i changed the docs, but when i follow the steps of the readme (even after i did yarn build) the example is not recognizing my new properties.

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit d82d82141bfbe529dfa8dfdab9389675124f2db8
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/635ed28521c2d000095b857a
Deploy Preview https://deploy-preview-1541--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandongregoryscott commented 1 year ago

one question: i changed the docs, but when i follow the steps of the readme (even after i did yarn build) the example is not recognizing my new properties.

The doc site references a published version of the package, so it won't pull in local changes without a little bit of work. I think we're probably OK to leave this change out of the doc site since we don't really call out internationalization for any other component docs.

brandongregoryscott commented 1 year ago

Thanks for the contribution, @KillerCodeMonkey!