segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Update ui-box, rip out `glamor` where possible #1543

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Overview

This PR updates our ui-box version to 5.2.1, which includes the ability to define selectors! Unfortunately it looks like most of the glamor references are related to keyframes / animations, which we don't have support for yet. This is step 1 of hopefully 2 for ripping out glamor!

Screenshots (if applicable)

The stories for each component (Avatar, Badge, SearchTableHeaderCell, and Toast) that was changed can be used to verify the changes haven't had a visual/functional regression.

~Update: looks like the style prop is broken now, which breaks the Avatar and the layout of the Badge stories. Holding off until https://github.com/segmentio/ui-box/issues/120 is fixed.~ Fixed!

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 9cd7c41ea2fad968eaaac19df4434f14fbf41264
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/636d61e718cdff0008bfadef
Deploy Preview https://deploy-preview-1543--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.