segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Update ui-box, remove keyframes from bulk of remaining components #1547

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Overview

This PR is a follow-up to the last (#1543), which leverages the new keyframes function from ui-box@5.3.0 to rip out more glamor references.

There are ~3 references remaining that will probably require a breaking change in the Positioner component (which passes a css object as render props to the child), as well as a change in useStyleConfig that splits out compatible Box props and sends the rest to css from glamor. I'm thinking we'll need to construct a style object and pass that along. There will probably need to be some more rugged testing to make sure that those changes still work as intended. But as far as these changes, they should more or less be 1:1 to what is currently working.

Screenshots (if applicable)

The components that have been changed can be compared side-by-side with the production Storybook instance:

Production Branch Reviewed
Corner Dialog Corner Dialog
Dialog Dialog
Overlay Overlay
Pulsar Pulsar
SideSheet SideSheet
Switch Switch
Toast Toast

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 2a0291ac9ead98c6d4ad260d5ab341312ef8d288
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/637519712febf20008ec4119
Deploy Preview https://deploy-preview-1547--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.