Closed brandongregoryscott closed 1 year ago
Name | Link |
---|---|
Latest commit | 05e0411a48876873bfbe694587a4f3839c591201 |
Latest deploy log | https://app.netlify.com/sites/evergreen-storybook/deploys/6386294f014ba000093acf70 |
Deploy Preview | https://deploy-preview-1554--evergreen-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Overview
This PR removes
glamor
(as well asclassnames
) from our dependencies and relies almost solely onui-box
for styling (defaulting to an in-linestyle
object where props are unhandled). There are some breaking changes:selectors
key, which is passed to theselectors
Box prop. Any consumers overriding these values in a custom theme will need to follow suit.Positioner
component'scss
value now returnsBoxCssProps
[due to theselectors
change], so it isn't 1:1 compatible if consumers were leveraging this component in a similar fashion by creating a classname withglamor
.Additional thoughts:
classicTheme
since it hasn't been maintained/supported and isn't worth the effort in retrofitting for this change. (#1559)Nudge
,SegmentedControl
andSidebarTab
components. I wrote a codemod in one of my TypeScript port branches that could port most of theNudge
andSidebarTab
instances over toPulsar
andTab
respectively, so I could dig those up and include them for ease-of-migration. (#1558)Screenshots (if applicable)
Please see the Deploy Preview and compare it to the current production Storybook instance.
Documentation