Forward ref and box props to Pulsar to fix Tooltip rendering

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

https://evergreen.segment.com

MIT License

12.38k stars 830 forks source link

Forward ref and box props to Pulsar to fix Tooltip rendering #1565

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Overview

This PR resolves the issue described in #1564 where Tooltips aren't being rendered when wrapping the Pulsar component. The ts definitions/prop types have been updated to reflect that Box props can be forwarded to the top-level Pane.

Screenshots (if applicable)

ezgif com-gif-maker

Documentation

[x] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[x] Added / modified Storybook stories

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name	Link
Latest commit	a0f1fd95c5bd08dbd3ea76f344b162e2e9f9715c
Latest deploy log	https://app.netlify.com/sites/evergreen-storybook/deploys/638cf818cb76aa00093d785a
Deploy Preview	https://deploy-preview-1565--evergreen-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

segmentio / evergreen

Forward ref and box props to Pulsar to fix Tooltip rendering #1565

✅ Deploy Preview for evergreen-storybook ready!

Deploy Preview for evergreen-storybook ready!