segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Fix incorrect default border color for TextInput #1587

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Overview

Resolves #1581

For some reason we were applying a border: 1px solid transparent style in the base Input theme object, and then overriding it individually in the default appearance object with a borderColor prop. I don't think this was intentional, so I've made the default border color gray400 and explicitly set the transparent border in the none appearance object, and added a few tests. Aside from this, I believe there's a deeper issue in ui-box where shorthand props + individual props can conflict depending on when they are added to the stylesheet/used, but that's an issue to tackle another day.

Screenshots (if applicable)

FileUploader story

image

TextInput story (no change)

image

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit d8748a13520b72e7c8875fa1dc3789de7cf320fc
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/63d920800181070008e8bd5d
Deploy Preview https://deploy-preview-1587--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.