Closed brandongregoryscott closed 1 year ago
Hi @brandongregoryscott Can you assign me this issue, this is my first open source contribution, would love to work on it. Thanks.
@Himu1503 We don't assign issues to non-Segment contributors, but contributions are always welcome. Take a look at our contributing guidelines and open up a PR when your work is ready!
After removing the classic/deprecated default themes in the v7 branch, I noticed we're only using
tinycolor2
in one place: theBadge
component theme. https://github.com/segmentio/evergreen/blob/master/src/themes/default/components/badge.js#L19After running this code in the console, it looks like
isLight
returns true foryellow
andorange
, however - I don't think this fallback object is ever really hit. Let's verify that we prevent users from passing arbitrary colors (i.e. anything other than the keys offills.colors
) and remove this dependency/unnecessary code.