segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.38k stars 830 forks source link

Textarea component loses borders under certain conditions #1609

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

Similar to #1581, after https://github.com/segmentio/evergreen/releases/tag/v7.1.0 we noticed the Textarea component can lose its borders in certain conditions. One way to reproduce is:

  1. Open https://evergreen-storybook.netlify.app/?path=/story/file-uploader--fileuploader
  2. Click the Textarea story
image

Note that just opening https://evergreen-storybook.netlify.app/?path=/story/textarea--overview or hard-refreshing solves the issue. We should remove the border: none that's also in its internal styles...

https://github.com/segmentio/evergreen/blob/3c6184d3ada0ba4d3bae7996c6d9f46aa60cca01/src/textarea/src/Textarea.js#L16-L17