Bug 1602 combobox button

[JeevantheDev]

Overview

• Created a props named as intent (type as string) for Combobox component and set default value 'input'.
• For Button component styles set another if condition inside borderColorForIntent function which will check for intent is equal to 'input'. If satisfied it will add the borderColor same as TextArea border.
• For Button disabled same condition updated.

  1602 Reference Bug

  Screenshots (if applicable)

  

Documentation

• [x] Updated Typescript types and/or component PropTypes
• [ ] Added / modified component docs
• [ ] Added / modified Storybook stories

[netlify[bot]]

✅ Deploy Preview for evergreen-storybook ready!

Name	Link
🔨 Latest commit	96f6c57176bbdbefc8e9095af1eb1425333654e1
🔍 Latest deploy log	https://app.netlify.com/sites/evergreen-storybook/deploys/63df8fac8b08590009cfbf68
😎 Deploy Preview	https://deploy-preview-1614--evergreen-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[brandongregoryscott]

Hey @JeevantheDev, thanks for the PR. I don't think adding an input intent really fits in with the current API (other intents are danger, warning, success and none, which is the default). Additionally, this does not make the make the border color match the TextInput when focused (still not sure if it should, since our standard Buttons don't, but this component is a form element composed of both.. 🤔 )

I wish I had a better suggestion for how to properly implement this right now, but it requires partially overriding the selectors that are setup in the Button component which isn't very obvious, even to me. Since the Combobox has been like this for so long, I don't think this is a huge priority to fix right now.