segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.36k stars 833 forks source link

LinkProps.target should be `HTMLAttributeAnchorTarget | undefined` #1642

Closed brandongregoryscott closed 1 year ago

brandongregoryscott commented 1 year ago

The current target prop typed to a string allows you to specify anything - I've seen variations of blank and __blank, while the correct target the developer was looking for is _blank. React comes with a built-in type union for this, so we might be able to use that: HTMLAttributeAnchorTarget

image