segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.36k stars 833 forks source link

Add .ogg supported mime type #1651

Closed camielvs closed 1 year ago

camielvs commented 1 year ago

Overview Hey! Really super quick PR to add the .ogg audio file format as a supported mime type for the File Uploader component.

I am currently using the File Uploader exclusively for .ogg files. It runs into problems when removing a file from the FileCard list because rebaseFiles tries to verify the remaining files against your list of supported mime types.

In future you could consider splitting this out into .oga (audio), .ogv (video) and .ogx (application) mime-types, but for now it's probably fine to use the more general .ogg for just audio.

Thanks!

Screenshots (if applicable)

Documentation

netlify[bot] commented 1 year ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit bb8d901587b3d82d2a938762a3fc88c61dae29e5
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/64934891086bc00008450a5f
Deploy Preview https://deploy-preview-1651--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandongregoryscott commented 1 year ago

Thanks @camielvs!