search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.36k stars 833 forks source link

fix: add optional prop "name" to RadioGroupOwnProps in index.d.ts #1666

Open jfelege opened 10 months ago

jfelege commented 10 months ago

Overview

While attempting to set name prop on the ; encountered a typing issue where name was not defined, however, based on the public docs/propTypes it should be allowed.

<RadioGroup
  name="is_private"
  ...
/>

The type definition changes might have been introduced with https://github.com/segmentio/evergreen/pull/1344.

Screenshots (if applicable)

Screenshot 2023-09-16 at 11 23 10 AM

Documentation

netlify[bot] commented 10 months ago

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 4cc87804cf4b068691436b3d87aa29041939a115
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/6505d708a072d8000871e9ad
Deploy Preview https://deploy-preview-1666--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.