Go1.16 cannot run tests

segmentio / kafka-go

Kafka library in Go

MIT License

7.52k stars 780 forks source link

Go1.16 cannot run tests #1280

Closed loktarjugg closed 4 months ago

loktarjugg commented 5 months ago

I am using go1.16. When running tests, I encountered an error "unix/syscall.go:83:16: undefined: unsafe.Slice". Upon further investigation, I found that the kafka-go package references testify v1.8.0, which requires at least go1.17. This prevents me from executing the tests.

Is it possible to downgrade testify to v1.7.0?

erikdw commented 5 months ago

I don't work much in this project, but it seems really unlikely this would be a good idea.

isaacd9 commented 5 months ago

Go 1.16 was released in February of 2021 and is 3 years out of date. I think probably the right solution here is to bump the required Go version to something more modern? https://github.com/segmentio/kafka-go/blob/main/go.mod#L3