search

segmentio / myth

A CSS preprocessor that acts like a polyfill for future versions of the spec.
4.33k stars 131 forks source link

Add Node 6 support. #143

Closed pin3da closed 4 years ago

pin3da commented 8 years ago

It should solve #137 , #138 and #142

zeke commented 8 years ago

:metal:

jreut commented 8 years ago

Is there anything that needs doing before this PR can be accepted? I'm happy to help, as I'd like to use Myth under Node v6!

zeke commented 8 years ago

Is there anything that needs doing before this PR can be accepted?

Node 6 should be added to .travis.yml to ensure it's working.

If that passes I would happily merge this, but I'm not an owner of the npm package... one of the owners would need to be pinged to publish a new release.

pin3da commented 8 years ago

@zeke Node 6 was already added in 3e493ed38545

zeke commented 7 years ago

cc npm package owners: @dominicbarnes, @MoOx, @ianstormtaylor

I tried to come up with a one-liner to collect the github handles of the npm package owners, but I fell short. I got this far:

$ npm i -g npm-user-cli && npm owner ls myth | cut -d' ' -f1
dominicbarnes
ianstormtaylor
moox
segment-admin
segmentio

I thought I could pipe that to xargs npm-user, but it only executed the search for the first result, dominicbarnes. Any xargs / exec wizards in the house?

MoOx commented 7 years ago

FYI, I am now the maintainer of a project that achieve the same goal called cssnext based on another engine (postcss). This projects support way more features and works in various versions of node ;)

sbrl commented 7 years ago

@MoOx Looks awesome! I think I'll use that instead then :-)

sbrl commented 7 years ago

And @zeke, I think you want the -I {} switch to xargs:

npm i -g npm-user-cli && npm owner ls myth | cut -d' ' -f1 | xargs -I {} npm-user {}

That limits it to 1 item per run of the command. Alternatively, you could do xargs -n 1 npm-owner instead I think.

sbrl commented 4 years ago

Any particular reason for closing this @pin3da? Leaving a comment would be really helpful.

It's confusing when a PR gets closed for seemingly no reason with no explanation :-/

pin3da commented 4 years ago

Sorry for closing it without any comment ):

The main reason is I was cleaning some open PRs, and this one did not have any activity in the last years. Also, I haven't been involved with nodejs in a while.

If there is still an interest/need on it, I can open it again and fix what is necessary.