search

segmentio / myth

A CSS preprocessor that acts like a polyfill for future versions of the spec.
4.32k stars 131 forks source link

Resolves #72 support for rebeccapurple #73

Closed jonathanKingston closed 10 years ago

MoOx commented 10 years ago

:+1:

ianstormtaylor commented 10 years ago

Thanks!

Would be better to add a test to the "features" folder, since that other one is mostly just for throwing big files so that we can be sure they don't fail to be parsed.

jonathanKingston commented 10 years ago

Will fix late tomorrow; missed that directory completely. Thank you

jonathanKingston commented 10 years ago

@ianstormtaylor let me know if you need further changes; thank you.

MoOx commented 10 years ago

@jonathanKingston can you squash your commits into one before merging please ? (now I can handle the merge ^^) Btw, for the feature test, you can just keep the first selector, it's enough to check plugin is correctly used, since your plugin should take care of the entire test suit (& it does).

After that we will be good to merge !

jonathanKingston commented 10 years ago

@MoOx ready to merge this time; I slapped my hands as I didn't make a feature branch for the merging. Should be good to go though. Thanks and congrats on becoming a collaborator.

MoOx commented 10 years ago

Awesome. Thanks ! I want to release that as 1.1 as soon as @ianstormtaylor give me publish access :) (1.1 will include @import changes too)