search

segmentio / myth

A CSS preprocessor that acts like a polyfill for future versions of the spec.
4.32k stars 131 forks source link

Empty font-feature-settings #79

Closed runeimp closed 10 years ago

runeimp commented 10 years ago

I upgraded this morning to the latest version of myth and started getting the following error:

/Users/mgardner/Projects/vhost/com/mynuvotv/com.mynuvotv.www/build/node_modules/myth/node_modules/rework-inline/node_modules/css/node_modules/css-parse/index.js:62
    throw err;
          ^

After much debugging I finally found that Myth was adding the following to my output CSS whenever font-variant; was present and set to either normal or inherit

-webkit-font-feature-settings: ;
-moz-font-feature-settings: ;
font-feature-settings: ;

Using empty values instead of normal. If set to small-caps it would set:

-webkit-font-feature-settings: "c2sc";
-moz-font-feature-settings: "c2sc";
font-feature-settings: "c2sc";

I'm guessing this is a specific issue to Autoprefixer but wasn't certain if maybe one of the other new implementations (love rework-inline addition) maybe the culprit.

BTW, thank you, thank you, THANK YOU for creating Myth! :-D

MoOx commented 10 years ago

It's probably a rework-font-variant issue. Nothing seems defined here for the font-variant shortand. I made some test, it's totally not related to autoprefixer. Can you open an issue on this repo with what you expect with different values so we can quikly add tests to fix that ? Thanks !

MoOx commented 10 years ago

I just said some shit about "nothing seems defined here" since there is actually all property. We should just add normal & inherit somewhere right ?

MoOx commented 10 years ago

Will close when it will be ok for Myth :)

MoOx commented 10 years ago

Here is the associated pr https://github.com/ianstormtaylor/rework-font-variant/pull/1