search

segmentio / myth

A CSS preprocessor that acts like a polyfill for future versions of the spec.
4.32k stars 131 forks source link

Add a huge GitHub css to ensure myth is fast (at least for parse/stringify) #83

Closed MoOx closed 9 years ago

MoOx commented 10 years ago

I assume that for a big CSS like that, 300ms is a max on a developer machine. What do you think about that @ianstormtaylor ?

The build is failing because travis is a bit slow a it take twice the time it take on my setup (iMac 3.2ghz icore5). More than 400ms.

What value will you consider has fast for a huge CSS like this one ? Maybe we should not add this a test ?

ianstormtaylor commented 10 years ago

Def +1 to adding the GitHub css file. We should grab a few others maybe too, like Apple or Stripe.

I think maybe instead of adding the test for speed, what if we added a make benchmark target that would run Myth a bunch of times over the files and then output the time taken for each of them. And then when we're adding new potentially slow features we can just make benchmark on master and the feature branch to see the difference

MoOx commented 10 years ago

Yeah good idea.

kevinSuttle commented 9 years ago

Some options: https://github.com/mrmrs/cssstats https://github.com/topcoat/topcoat/tree/master/dev/test/perf/telemetry

ai commented 9 years ago

GitHub styles is a bad way, because they do not contain whitespaces.

In PostCSS vs Preprocessors vs Rework benchmark I use Bootstrap: https://github.com/postcss/benchmark/blob/master/preprocessors.js