fix nsqlookup bug when registering nodes

segmentio / nsq-go

Go package providing tools for building NSQ clients, servers and middleware.

MIT License

100 stars 20 forks source link

Closed achille-roussel closed 7 years ago

achille-roussel commented 7 years ago

The issue with nsqlookup:

for some reason the nodes disconnected
they tried to re-identify to nsqlookup when they connected
nsqlookup kept a cache of the nodes it knew about, refused to re-identify because the previous session expired

The fix here is to always obey the calls to RegisterNode, if the method is called nsqlookup always discards the existing session for a new one.

Please take a look and let me know what you think about this.

thehydroimpulse commented 7 years ago

💥 🚢 LGTM!

thehydroimpulse commented 7 years ago

thanks a lot for the quick PR!

achille-roussel commented 7 years ago

You're welcome.