Closed calvinfo closed 8 years ago
The reason the tests are flakey with a single topic name is that I'm pretty sure the nsqlookups don't atomically delete the topic over the course of the request. It's quick enough on the local machine, but on circle it makes for a much flakier set of tests.
maybe i missed it in the diff, but can you add a test for "adds reader connection post after construction"?
@juliangruber, good call–done!
LGTM!
thanks guys!
This commit introduces several changes
This last bullet allows the reader to add event handlers before the connection is made.