search

segmentio / nsq.js

NSQ client for nodejs
203 stars 34 forks source link

Add message callbacks #73

Open promag opened 8 years ago

promag commented 8 years ago

Add optional callbacks for Message.finish, Message.requeue and Message.touch.

The image used in CircleCI must be Ubuntu 14.04 to be able to use nsq@0.3.8.

This PR also partially reverts the work done in #70. To fix the test suite we must ensure no reader is left at subscribe state before the tests end, otherwise the next test can fail because nsqd can deliver the message to the other reader.

promag commented 8 years ago

@calvinfo Care to take a look?

jcrugzz commented 7 years ago

@thehydroimpulse any issues with this? Seems reasonable.

thehydroimpulse commented 7 years ago

sorry for the delay here @promag @jcrugzz. I'll take a look at this and merge it in.

promag commented 7 years ago

@thehydroimpulse ping.

doron2402 commented 7 years ago

Are you guys planing on merging this?