search

segmentio / nsq.js

NSQ client for nodejs
203 stars 34 forks source link

Update nsq-lookup #79

Closed jcrugzz closed 7 years ago

jcrugzz commented 7 years ago

Trying to get this to work on the latest node. Currently this is using my fork of nsq-lookup until https://github.com/segmentio/nsq-lookup/pull/5 is merged. Wanted tests to run on CI

jcrugzz commented 7 years ago

@thehydroimpulse could circle.ci be configured to run on PRs as well? and any assistance with both this and nsq-lookup would be great :).

thehydroimpulse commented 7 years ago

Thanks for the PR. I enabled ci on PRs but you may need to close and reopen

jcrugzz commented 7 years ago

@thehydroimpulse will update with latest nsq-lookup whenever version is bumped :).

jcrugzz commented 7 years ago

@thehydroimpulse only fails due to timing and publish status of nsq-lookup. If y'all want help and are willing to give privileges, I'm happy to assist. Thanks again for the quick response!

jcrugzz commented 7 years ago

@thehydroimpulse any chance we could have https://github.com/segmentio/nsq-lookup published so we can get this merged and published as well? Thanks!

thehydroimpulse commented 7 years ago

hey @jcrugzz sorry for the delay here. I just published nsq-lookup to npm

jcrugzz commented 7 years ago

@thehydroimpulse great thanks :). This one should be good to go then

thehydroimpulse commented 7 years ago

Thanks again for the PR!