segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 104 forks source link

remove parquet.BufferedPage specialization #303

Closed achille-roussel closed 2 years ago

achille-roussel commented 2 years ago

Based on #297, this PR removes the parquet.BufferedPage interface. I found that the complexity cost of separating the Page concept between parquet.Page and parquet.BufferedPage was off, and almost all the parquet.Page implementations we had in the package satisfied parquet.BufferedPage.

The PR merges parquet.BufferedPage into parquet.Page.