segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 58 forks source link

remove pprof labels #307

Closed achille-roussel closed 2 years ago

achille-roussel commented 2 years ago

Based on https://github.com/segmentio/parquet-go/pull/297, I added these as part of #301, without really having a use case for it.

The pprof labels API are heavily reliant on heap allocations due to requiring the use of context.Context, and create a lot of noise in memory profiles.

We can revisit later if we end up needing this kind of debugging features, for now let's keep it simpler?