segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 58 forks source link

do not zero bufferedPages when they are released #383

Closed achille-roussel closed 2 years ago

achille-roussel commented 2 years ago

Follow up to #380, we change mistakenly inherited the logic of zeroing out the page, which was only valid to do where the Retain function did not exist.

Since an application may call Retain multiple times, zeroing the fields on the first Release call may invalidate shared references to the page.