search

segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 58 forks source link

Build status badge shows failing tests #402

Closed tschaub closed 2 years ago

tschaub commented 2 years ago

I was curious if it was intentional that the tests are not run on the default branch. As it is now, the build status badge often shows failing tests since the latest action might be from any PR.

image

I understand there might be a good reason that the tests are not run on main. If not, would a change like this be acceptable: https://github.com/segmentio/parquet-go/compare/main...tschaub:parquet-go:test-main ?

achille-roussel commented 2 years ago

Thanks for reporting!

Your suggestion to show the badge for tests run on the main branch sounds good, I don't think the current configuration is intentional.

However, I'm confused about the suggested change to the GitHub action file. Would you have more details to share about why it is needed?

kevinburkesegment commented 2 years ago

Badges?

19375577028_018dd0a6c9_b

tschaub commented 2 years ago

@achille-roussel - I opened #403 and left a little more detail there.