search

segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 102 forks source link

Move parquet.BufferPool to a different package #447

Open achille-roussel opened 1 year ago

achille-roussel commented 1 year ago

This issue is opened to discuss the concern raised in https://github.com/segmentio/parquet-go/pull/437#issuecomment-1343179001

I renamed parquet.PageBufferPool to parquet.BufferPool. I'm a bit concerned that it could get confusing since there is a parquet.Buffer type which has nothing to do with it, I'm considering moving parquet.BufferPool to a subpackage to avoid the confusion but haven't made up my mind on a name for the package either so for now this is the way.

We need to figure this out before make a v1.0 release.