search

segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 102 forks source link

io.ReaderAt interface acceptance is dishonest #482

Open danwt opened 1 year ago

danwt commented 1 year ago

Hi

parquetx.NewGenericReader takes an io.ReaderAt as input but later makes further assumptions on the interface

https://github.com/segmentio/parquet-go/blob/674602166e6d91f883e85ceba8ef3f13c9e9c86a/reader.go#L154-L168

so the function is not actually usable with an io.ReaderAt.

Thanks