Closed ty-sentio-xyz closed 1 year ago
Thanks for the comments.
I've updated the PR with a new test case that covers the case.
Not sure this is the right way of doing it but I am separating these tests into two files:
column_index_test.go
: sits in parquet_test
package to test public members of parquet
package.column_index_internal_test.go
: sits in parquet
package so that private methods can be tested.The new test case is:
column_index_test.go:TestBinaryColumnIndexMinMax
: where we construct a few min-max indexes and searches, to verify the behavior of min-max index for both fixedLenByteArray and byteArray type (and the test would fail if we comment out the part where byte array gets incremented).
Byte array will be increased by 1 after truncated, for both byteArrayColumnIndexer and fixedLenByteArrayColumnIndexer.
This is to make sure truncated values are lexicographically correct, when comparing truncated value with actual max value.