segmentio / parquet-go

Go library to read/write Parquet files
https://pkg.go.dev/github.com/segmentio/parquet-go
Apache License 2.0
341 stars 102 forks source link

Add support for writing Go int16 type #505

Open chelseajonesr opened 1 year ago

chelseajonesr commented 1 year ago

This PR adds support for writing int16 values. (Currently trying to write a Go struct with int16 values causes the error panic: cannot convert Go values of type int16 to parquet value.)

I based the writeRowsFuncOfInt16 function on the existing writeRowsFuncOfTime and tried to add test cases wherever they seemed appropriate.

The "int16" scenario in writer_test.go is comparing against output from my locally built version of parquet-tools, and I noticed that it's creating slightly different output for some of the other scenarios, so it may need to be changed to pass the official build process.