search

segmentio / stack

A set of Terraform modules for configuring production infrastructure with AWS
https://open.segment.com
MIT License
2.1k stars 420 forks source link

Add final_snapshot_identifier to `rds` #131

Closed tysonmote closed 7 years ago

tysonmote commented 7 years ago

This allows rds resources to be destroyed. Currently, destroys fail with an error because we haven't specificed a name for the final snapshot.

rds-cluster has this already.

tysonmote commented 7 years ago

@tejasmanohar You'll also want to pull this in to your rds_replica branch because it's breaking the warehouse terracode builds.

tejasmanohar commented 7 years ago

What's the potential impact for existing RDS? Is it possible someone has set an existing final_snapshot_id already? I guess not since this module doesnt allow for it? LGTM if you've thought through that case

tejasmanohar commented 7 years ago

I will rebase my branch against master when this is merged

tysonmote commented 7 years ago

@tejasmanohar I'll go ahead and handle the merge in to your branch.

tysonmote commented 7 years ago

This is merged. Unfortunately any already-created rds modules will still need to be manually destroyed, but this will fix destroys for all new rds modules in the future.