fix netstat metric names

segmentio / stats

Go package for abstracting stats collection

https://godoc.org/github.com/segmentio/stats

MIT License

208 stars 32 forks source link

fix netstat metric names #108

Closed achille-roussel closed 5 years ago

achille-roussel commented 5 years ago

Follow up of #90 which fixed a backward incompatible change, but kind of broke the (rarely used) API...

We could have done a better job managing major versions with this package, not sure if this should represent a major version bump or not. Let me know what you think!

abraithwaite commented 5 years ago

:man_shrugging: I don't have a strong opinion on it . How'd it break the API? Maybe that can inform whether or not we bump the version.

achille-roussel commented 5 years ago

We supported metric names with <metric name>:<field name>, now the model is <metric name>.<field name> where the last dot is assumed to be the start of the field name.

I doubt anyone depended on this because it wasn't documented 🤷‍♂

abraithwaite commented 5 years ago

:shipit: