Closed colinking closed 4 years ago
@achille-roussel added a note to the README here: https://github.com/segmentio/stats/tree/colin-go-version#processes
LMK if that looks good to you!
I'll tag as v4.6.0 and add a note on this change in the release notes.
Ugh my formatter had some fun with the README... one sec
Fixed!
Most of our services will set a version tag that represents the version of their service. However, the Go stats reported by the
procstats
package will overwrite this tag with the current Go runtime version.This becomes a bigger issue when scraping these stats via Prometheus, since it will consider a sample as invalid if labels are not unique:
This PR makes a breaking change to resolve this issue, by renaming the tag that specifics the Go runtime version from
version
togo_version
.