segmentio / stats

Go package for abstracting stats collection
https://godoc.org/github.com/segmentio/stats
MIT License
208 stars 32 forks source link

Introduce a flag that skips tag duplicate removal logic #165

Closed sungjujin closed 3 months ago

sungjujin commented 3 months ago

This pull request primarily introduces a new feature to the Engine struct in engine.go which allows the skipping of duplicate tag removal in the metrics reporting process. This feature is tested in engine_test.go.

The most important changes are:

New feature:

Feature integration:

Testing:

Contexts

image

https://twilio.slack.com/archives/CPLTV1V9A/p1720735336325819

sungjujin commented 3 months ago

@kevinburkesegment would you please review again? Thank you!

sungjujin commented 3 months ago

@kevinburkesegment I just wanted to follow up. Could you please review this PR when you have a moment? Thank you so much!