segmentio / stats

Go package for abstracting stats collection
https://godoc.org/github.com/segmentio/stats
MIT License
208 stars 32 forks source link

allow use of unsorted labels #42

Closed achille-roussel closed 7 years ago

achille-roussel commented 7 years ago

We noticed performance issues on one of our applications due to the fact that the metric labels need to always be used in a consistent order, one way to achieve it is sorting them, another is to rely on the fact that the tags are always presented in the same order.

The intent of this pull request is to offer the program the option to skip the sorting step if it can guarantee that it won't generate metrics with reordered tags.

achille-roussel commented 7 years ago

Thanks for the review!