search

segmentio / stats

Go package for abstracting stats collection
https://godoc.org/github.com/segmentio/stats
MIT License
208 stars 32 forks source link

Panic #73

Closed danielstjules closed 6 years ago

danielstjules commented 7 years ago

Getting the occasional panic from the stats pkg. Making note of it here and will debug later.

10-18 10:50:50 INFO - vendor/github.com/segmentio/stats.(*Buffer).HandleMeasures(0xc4202af108, 0xbe7202fe84aca2d5, 0x17f403f15451, 0xd98060, 0xc422a81680, 0x1, 0x1)
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/buffer.go:76 +0x4a3
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/datadog.(*Client).HandleMeasures(0xc4202af0e0, 0xbe7202fe84aca2d5, 0x17f403f15451, 0xd98060, 0xc422a81680, 0x1, 0x1)
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/datadog/client.go:81 +0x6d
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats.(*Engine).measure(0xc4202baa40, 0xa41fd2, 0x9, 0x95b340, 0xaa8e70, 0x0, 0xc423234160, 0x1, 0x1)
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/engine.go:125 +0x3a4
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats.(*Engine).Add(0xc4202baa40, 0xa41fd2, 0x9, 0x95b340, 0xaa8e70, 0xc423234160, 0x1, 0x1)
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/engine.go:84 +0x82
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats.(*Engine).Incr(0xc4202baa40, 0xa41fd2, 0x9, 0xc423234160, 0x1, 0x1)
10-18 10:50:50 INFO - vendor/github.com/segmentio/stats/engine.go:79 +0x75
achille-roussel commented 7 years ago

Can you paste the full trace with info about the reason of the panic?

Also can you confirm your program is built with the latest version of the package?

danielstjules commented 7 years ago

Good call! Bumping the pkg, we were running on 3c8440aef9edc2fc7a9c7581e25c02f765ce5e6f I'll go through the logs later and find the full trace. Possible it's already been fixed!

danielstjules commented 6 years ago

Haven't been able to reproduce with the latest release :)