Improve `cross-rack` replication checks (#138)

segmentio / topicctl

Tool for declarative management of Kafka topics

MIT License

580 stars 54 forks source link

Closed eMuMuMu closed 1 year ago

eMuMuMu commented 1 year ago

If --validate-only is set the number of racks needed is ignored.

If there are broker connections, use the actual number of racks in the cluster.

Use /bin/bash for set_up_net_alias.sh. [[ … ]] is a bashism and doesn’t work with all sh.

eMuMuMu commented 1 year ago

Sorry - wrong account...

joewreschnig commented 1 year ago

The actual PR is https://github.com/segmentio/topicctl/pull/140, I accidentally filed it with one of our company's non-human accounts.