segmentio / topicctl

Tool for declarative management of Kafka topics
MIT License
590 stars 55 forks source link

Improve `cross-rack` replication checks (#138) #140

Closed joewreschnig closed 1 year ago

joewreschnig commented 1 year ago

If --validate-only is set the number of racks needed is ignored.

If there are broker connections, use the actual number of racks in the cluster.

Use /bin/bash for set_up_net_alias.sh. [[ … ]] is a bashism and doesn’t work with all sh.

petedannemann commented 1 year ago

@joewreschnig thanks for your contribution! I just cut release 1.10.0 and included this in it https://github.com/segmentio/topicctl/releases/tag/v1.10.0