segmentio / utm-params

parse and get all utm parameters

MIT License

41 stars 7 forks source link

Update Readme for CircleCI badge #6

Closed rishimkumar closed 5 years ago

rishimkumar commented 7 years ago

Noticed your badge was broken - I believe this should fix it. Can manually confirm: https://circleci.com/gh/segmentio/utm-params/tree/master.png?style=badge

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request head (patch-1@25d12ac).

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cfebf8...25d12ac. Read the comment docs.

bostonaholic commented 7 years ago

You also might want to cycle the token that was made public. If it's a token with only 'read' access, it shouldn't be needed since this project is public. If the token has write access, I would revoke it.

rishimkumar commented 7 years ago

it may be the interest of the maintainer to close my PR and/or replace the line with this: https://circleci.com/gh/segmentio/utm-params/tree/master.png?style=shield as the original went for the shield style.

Here is the badge style. https://circleci.com/gh/segmentio/utm-params/tree/master.png?style=badge

Either of these will work though.

rishimkumar commented 5 years ago

this doesn't look maintained anymore so the broken badge is actually kinda helpful to end user :p Closing PR. thanks!