search

segmentio / xml-parser

simple non-compliant xml parser for nodejs
101 stars 36 forks source link

allow attribute with a hyphen #4

Closed tnguyen14 closed 10 years ago

tnguyen14 commented 10 years ago

this fixes #3

gjohnson commented 10 years ago

Cool, can you add a test? Thanks!

tnguyen14 commented 10 years ago

@gjohnson on it! btw, while trying to run test, I realized that the test/index.js file needs this declaration (probably because I don't have should installed globally):

var should = require('should');
tnguyen14 commented 10 years ago

Added the test case. Please help me review it.

gjohnson commented 10 years ago

LGTM

tnguyen14 commented 10 years ago

Thanks!

gjohnson commented 10 years ago

Available in 1.1.0

tnguyen14 commented 10 years ago

Thanks. I was gonna ask that next. Any idea of when the release might be? On Oct 4, 2014 6:30 PM, "Garrett Johnson" notifications@github.com wrote:

Available in 1.1.0

— Reply to this email directly or view it on GitHub https://github.com/segmentio/xml-parser/pull/4#issuecomment-57920544.

gjohnson commented 10 years ago

@tnguyen14 already released :-)