search

segrelab / cometspy

Python interface for running COMETS simulations and analyzing the results
GNU General Public License v3.0
11 stars 9 forks source link

Media index bug #8

Closed sulheim closed 3 years ago

sulheim commented 3 years ago

The main contribution is here one single line self.media = self.media.reset_index(drop=True) in layout.py that resolves an issue I encountered several times with non-unique indices in the self.media dataframe.

The other addtitions are a very basic .gitignore file and two helper functions to get variables - I can remove this edits if they are unwanted.

jeremymchacon commented 3 years ago

That all looks good to me--the only thought is that self.reactions.loc[self.reactions['EXCH'], "REACTION_NAMES"] returns a pandas series, I think, not a list. Maybe coerce it to a list first?

jeremymchacon commented 3 years ago

Also, just wondering, what bugs were you encountering that are fixed by the drop = True call?

sulheim commented 3 years ago

Also, just wondering, what bugs were you encountering that are fixed by the drop = True call?

Don't remember :/ I haven't been working with cometspy the last few months.