search

segross / UnrealImGui

Unreal plug-in that integrates Dear ImGui framework into Unreal Engine 4.
MIT License
666 stars 211 forks source link

NetImgui Update 1_3 #44

Closed sammyfreg closed 3 years ago

sammyfreg commented 3 years ago

Updating Dear Imgui to 1,80 (with table support) and NetImgui to 1.3.

Tested on Unreal 4.26

Note: There only 2 changelist for the latest change. Other changes listed are from previous changes.

Frigerius commented 3 years ago

It seems this change introduces a new crash when cooking: Need to note I upgraded to 1.81 hope this doesn't contain this crashing code ^^' Looking at the code, Shutdown seems to get called with a nullptr context I found a fix, will comment the part in the review


  LogWindows: Error: === Critical error: ===
  LogWindows: Error:
  LogWindows: Error: Fatal error!
  LogWindows: Error:
  LogWindows: Error: Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000000000a8
  LogWindows: Error:
  LogWindows: Error: [Callstack] 0x00007ff92af0b36b UE4Editor-ImGui.dll!ImGui::Shutdown() [U:\Projects\Yggdrasil\Plugins\UnrealImGui\Source\ThirdParty\ImGuiLibrary\Private\imgui.cpp:4099]
  LogWindows: Error: [Callstack] 0x00007ff92af0bece UE4Editor-ImGui.dll!FImGuiModule::ShutdownModule() [U:\Projects\Yggdrasil\Plugins\UnrealImGui\Source\ImGui\Private\ImGuiModule.cpp:137]
  LogWindows: Error: [Callstack] 0x00007ff946989b45 UE4Editor-Core.dll!FModuleManager::UnloadModulesAtShutdown() [U:\UnrealEngine\Engine\Source\Runtime\Core\Private\Modules\ModuleManager.cpp:731]
  LogWindows: Error: [Callstack] 0x00007ff78fdc00c7 UE4Editor-Cmd.exe!FEngineLoop::Exit() [U:\UnrealEngine\Engine\Source\Runtime\Launch\Private\LaunchEngineLoop.cpp:4216]
  LogWindows: Error: [Callstack] 0x00007ff78fdc0bf7 UE4Editor-Cmd.exe!GuardedMain() [U:\UnrealEngine\Engine\Source\Runtime\Launch\Private\Launch.cpp:182]
  LogWindows: Error: [Callstack] 0x00007ff78fdc0c4a UE4Editor-Cmd.exe!GuardedMainWrapper() [U:\UnrealEngine\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:137]
  LogWindows: Error: [Callstack] 0x00007ff78fdd4e1d UE4Editor-Cmd.exe!WinMain() [U:\UnrealEngine\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:268]
  LogWindows: Error: [Callstack] 0x00007ff78fdd6eb2 UE4Editor-Cmd.exe!__scrt_common_main_seh() [d:\agent\_work\63\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288]
  LogWindows: Error: [Callstack] 0x00007ff9b5087034 KERNEL32.DLL!UnknownFunction []
  LogWindows: Error: [Callstack] 0x00007ff9b6b7d241 ntdll.dll!UnknownFunction []
segross commented 3 years ago

I'll just merge it without checking as I don't have right now any time. But I've seen a discussion above and I believe it works, so all good.